feat: chunked exec streaming (exec_chunk) — remove 10MB output ceiling (#116) - #119
Merged
Conversation
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
…#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds chunked exec streaming (
exec_chunk) — replaces the single 10MB-cappedexec_resultwith incremental base64-encoded chunks sent as stdout becomes available. Removes the 10MB output ceiling entirely.How
Capability negotiation: node advertises
exec_chunkinhello.capabilities; server echoes back inhello_ack.capabilities. Only active when both sides support it. Falls back to currentexec_result+ 10MB cap otherwise.Protocol (§3.7a):
exec_chunkmessages carryseq(monotonic),data(base64),more(true/false)more: false) carriesexit_code,status,duration_ms,truncatedchunk_sizeinconfig.toml(default 1 MiB, range 4 KiB–10 MiB)Go changes:
messages.go—TypeExecChunk,ExecChunkPayload,NewExecChunkEnvelopeHelloAckPayload— newCapabilitiesfieldclient.go— store server caps, exposeServerCapabilities()config.go—ChunkSizefield with clamped accessorshell.go—ChunkWritercallback in demuxer goroutine; flushes at chunk boundaryhandler_exec.go— dual-path: chunk streaming viaWriteEnvelopeor legacyexec_result;NoResponsefield onEnvelopesignals dispatcher to skip writedispatch.go—NoResponsecheckmain.go— wireWriteFunc,ChunkSize,SetServerCapabilitiesPROTOCOL.md— §3.7a spec + updated examplesTests: 7/7 packages pass with
-race.