test(status): add stale PID detection test for runStatus - #118
Merged
Conversation
The PID liveness check (signal 0) was already implemented in runStatus but had no test. This test writes a status file with state=connected and a dead PID (99999), then asserts the output shows 'stopped' — not 'connected' — proving the liveness check overrides the stale file. Closes #114 Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for the PID liveness check in
runStatus. The check itself was already implemented (signal 0) but had no test coverage.Test
TestRun_Status_StalePID:state: "connected"and a dead PID (99999)hermes-node status"stopped"— not"connected"— proving the liveness check overrides the stale fileCloses #114