fix: non-blocking chunk I/O — prevent broken pipe on fast chunk streams (#116) - #108
Merged
Conversation
…prevent event loop stall (#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chunked exec streaming disconnects with "broken pipe" around 22-24MB because the server's chunk handler does synchronous file I/O (
cs.file.write+cs.file.flush) inside the async WebSocket dispatch loop. When chunks arrive rapidly, the event loop blocks on disk writes, falls behind on reading the next message, the TCP receive buffer fills, and the connection resets.Fix
Wrap file write and flush in
loop.run_in_executor(None, ...)so disk I/O runs in a thread pool and never blocks the event loop.Tested
pytest tests/ -q— 46/46 pass