NYC -> C8 - #4221
Open
MicahMaphet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate from nyc to c8.
Motivation
nyc doesn't support ES modules while c8 does
Changelog
nycwithc8.nycrc.ymlfiles to.c8rc.json.mocharc.ymlfiles to.mocharc.json; addrecursive: trueandextension: ".test.js"nyc mocha 'ts_build/test/**/*.test.js') to directory specs (c8 mocha ts_build/test)bitcore-buildgulptest:nodetask fromnyctoc8c8config from package.json into.c8rc.jsontsxwallet.test.tstorequire()with paths corrected for the compiled location (ts_build/test/unit). Importing does type checking on bitcore-node which breaks.Testing Notes
Run all tests and compare coverage
c8 counts every line
C8:

NYC:

Checklist