fix!: attrs like hx-vals not respecting disinherit - #3952
Open
alirezaalavi87 wants to merge 1 commit into
Open
Conversation
- All attributes including hx-vals now respect hx-disinherit and htmx.config.disableInheritance - Write tests - This is a breaking change since some people might have relied on the previous behavior of not respecting disinherit for those attrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corresponding issue: #1119
Testing
Manual testing:
I created a sample project and imported this updated
htmx.jsinto it, and tested with such code snippets:Automated tests:
Added new tests with playwrite, testing the fixed issue and verifying that
hx-valsrespects disinheritance, both by configuration and byhx-disinheriton parent nodes.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeededNOTE:
I used LLMs to help me understand the issue and write the tests and fixes. I spent ~2 hours reviewing and nitpicking on the changes and understanding them. I am not much aware of the internal workings of HTMX so there might be some things that I'm missing. But the previous tests and the new tests all passed. I tried my best for this to be high quality.