fix: rib command dropping entries and using wrong RIB snapshot#133
Merged
Conversation
Two bugs in the RIB reconstruction lens: 1. Base RIB parser applied a start_ts filter at the RIB dump timestamp, silently dropping entries whose per-route timestamp (when the route was learned) predates the dump time. Stable routes learned days/weeks earlier were excluded. Fixed by using a separate safe_rib_filters() that omits time filters for base RIB loading. 2. Broker query used ts_end=target_ts, but the broker's ts_end filter is exclusive. A RIB starting exactly at the target timestamp was not returned, forcing selection of the previous RIB and replaying unnecessary update files (~3x slowdown for midnight RIB queries). Fixed by using last_ts+1. Also added tracing::info! progress logging for RIB loading and update replay, visible with --debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
start_tsfilter at the RIB dump timestamp, silently dropping entries whose per-route timestamp (when the route was learned) predates the dump time. Stable routes learned days/weeks earlier were excluded. Fixed by usingsafe_rib_filters()that omits time filters for base RIB loading.ts_end=target_ts, but the broker'sts_endfilter is exclusive. A RIB starting exactly at the target timestamp was not returned, forcing selection of the previous RIB and replaying unnecessary update files. Fixed by usinglast_ts + 1.tracing::info!progress logging for RIB loading and update replay (visible with--debug).