perf: refactor ignore logic to prevent duplicate work and allocations - #1898
Open
TimothyMakkison wants to merge 1 commit into
Open
perf: refactor ignore logic to prevent duplicate work and allocations#1898TimothyMakkison wants to merge 1 commit into
TimothyMakkison wants to merge 1 commit into
Conversation
Contributor
Author
|
After #1888 it would be worth switching most of these methods over to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1897, supports #1893
IgnoreList
alwaysIgnoredRulesto useIgnoreRule[], avoiding the cost of compiling the regex for each construction ofIgnoreListalwaysIgnoredRulesand the parsed rules we simply evaluate one after the other to avoid allocating aListor larger arrayIgnoreRule
TrimStart(ReadOnlySpan<char>overload to avoid reallocating astringfor every callSplitapi that returns aRangeinstead of creating substrings.Related feat: refactored benchmarks and added
CliBenchmarks#1896StringExtensions
Replace(charoverload #1897, avoids allocating a new string each callBenchmarks - from #1896
Note that timing isn't very accurate due to low iteration count
Before
After
Pretty large performance gains for
FormatCli, curious to see how large the real world impact will be.