32960 business emailer - special resolution updates#4557
Open
kialj876 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
kialj876
commented
Jul 7, 2026
|
|
||
| elif not is_coop: | ||
| # only add business email recipient for non-coop | ||
| else: |
Collaborator
Author
There was a problem hiding this comment.
the only case this was effecting for coops was annualReport which is now skipped earlier
|
kialj876
commented
Jul 7, 2026
| if filing.filing_type in submitter_recipient_filings: | ||
| optional_email = filing.filing_json["filing"]["header"].get("documentOptionalEmail") | ||
| if filing.submitter_roles and UserRoles.staff in filing.submitter_roles and optional_email: | ||
| if filing.submitter_roles and UserRoles.staff in filing.submitter_roles: |
Collaborator
Author
There was a problem hiding this comment.
if this is true and theres no optional email we don't actually want it to add the staff user email (reason for the change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32960
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).