Skip to content

32956 bug fix for cont in review status email publish#4556

Merged
kialj876 merged 2 commits into
bcgov:mainfrom
kialj876:32956-fix-cont-in-review-email-publish
Jul 7, 2026
Merged

32956 bug fix for cont in review status email publish#4556
kialj876 merged 2 commits into
bcgov:mainfrom
kialj876:32956-fix-cont-in-review-email-publish

Conversation

@kialj876

@kialj876 kialj876 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#32956

Description of changes:

  • these review emails aren't working in prod (likely unnoticed as its a rare filing)
    • region may not be defined (regular users can't set it for international jurisdictions), was leading to exception in emailer
    • enum was getting published from the API as the number instead of the name (i.e. '1' instead of 'AWAITING_REVIEW')

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 requested review from meawong and mruff-aeq July 6, 2026 19:17
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@kialj876 kialj876 merged commit bda1879 into bcgov:main Jul 7, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants