Skip to content

chore: remove unused CI FEATURES build-arg and dedupe compose image build #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazywriter1 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −11
Open

chore: remove unused CI FEATURES build-arg and dedupe compose image build #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ jobs:
settings:
- arch: linux/amd64
runs-on: ubuntu-24.04
features: jemalloc,asm-keccak,optimism
- arch: linux/arm64
runs-on: ubuntu-24.04-arm
features: jemalloc,optimism
runs-on: ${{ matrix.settings.runs-on }}
steps:
- name: Harden the runner (Audit all outbound calls)
Expand Down Expand Up @@ -63,8 +61,6 @@ jobs:
file: Dockerfile
tags: ${{ env.NAMESPACE }}/${{ env.RETH_IMAGE_NAME }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
FEATURES=${{ matrix.settings.features }}
platforms: ${{ matrix.settings.arch }}
outputs: type=image,push-by-digest=true,name-canonical=true,push=true

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ jobs:
settings:
- arch: linux/amd64
runs-on: ubuntu-24.04
features: jemalloc,asm-keccak,optimism
- arch: linux/arm64
runs-on: ubuntu-24.04-arm
features: jemalloc,optimism
runs-on: ${{ matrix.settings.runs-on }}
steps:
- name: Harden the runner (Audit all outbound calls)
Expand All @@ -39,6 +37,4 @@ jobs:
context: .
file: Dockerfile
push: false
build-args: |
FEATURES=${{ matrix.settings.features }}
platforms: ${{ matrix.settings.arch }}
5 changes: 2 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
services:
execution:
image: base-node:local
build:
context: .
dockerfile: Dockerfile
Expand All @@ -16,9 +17,7 @@ services:
env_file:
- ${NETWORK_ENV:-.env.mainnet} # Use .env.mainnet by default, override with .env.sepolia for testnet
node:
build:
context: .
dockerfile: Dockerfile
image: base-node:local
restart: unless-stopped
depends_on:
- execution
Expand Down