chore(apps): remove duplicate /apps landing page#1583
Open
crazywriter1 wants to merge 1 commit into
Open
Conversation
docs/apps/index.mdx was a byte-for-byte duplicate of docs/apps/quickstart/build-app.mdx (the page wired into the nav). Remove it, redirect /apps and /apps/index to /apps/quickstart/build-app, and drop the now-dead /apps/index entry from the generated llms indexes.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
docs/apps/index.mdxis a byte-for-byte duplicate ofdocs/apps/quickstart/build-app.mdx, which is the page wired into the Apps nav. Two identical 548-line files served at/appsand/apps/quickstart/build-appcreate duplicate content (SEO) and a maintenance hazard, since edits to one silently drift from the other.History suggests this is unintentional:
build-app.mdxlanded via #1363 ("updated docs"), and one day laterapps/index.mdxwas added in #1387 (a notifications-focused PR) with identical content, and has never been edited since.Changes
docs/apps/index.mdx.docs.json:/appsand/apps/index→/apps/quickstart/build-app(so the/appsURL keeps working)./apps/indexbullet fromllms.txtandllms-full.txt.Test plan
python3 -m json.tool docs/docs.json—docs.jsonis valid JSON after adding the redirects.node scripts/lint-mdx.js all— passes; no content errors. (The default changed-files mode reports a benignFile not foundfor the deleted page, since it diffs deleted paths; not run in CI.)node scripts/llms.js— confirms the only Apps-section change for this branch is dropping the/apps/indexentry;build-appremains indexed.index.mdx(Docs/notif endpoint update #1387) duplicatesbuild-app.mdx(updated docs #1363); nav already points tobuild-app, so/appsis only reachable by direct URL and is now redirected — no content lost.Notes for reviewers
/apps(rather than a redirect) is intentional, let me know and I'll instead makeindex.mdxa thin pointer tobuild-app.