Skip to content

test(smoke): pin composite policyType → IncompatiblePolicyType at the precompile boundary (BOP-476) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robriks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(smoke): pin composite policyType → IncompatiblePolicyType at the precompile boundary (BOP-476) #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions script/smoke/journeys/precompile_invariants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
POLICY = config.POLICY_REGISTRY
ALLOWLIST = config.POLICY_TYPE_ALLOWLIST
UNION = config.POLICY_TYPE_UNION
INTERSECT = config.POLICY_TYPE_INTERSECT

# Check names that are known/accepted divergences: reported, but do not fail the run.
INFORMATIONAL: set[str] = set()
Expand Down Expand Up @@ -95,6 +96,27 @@ def _enum_out_of_range_reverts(c: Chain, _probe) -> None:
c.expect_raw_revert("enum out of range", POLICY, bad_enum)


def _create_policy_composite_type_reverts(c: Chain, _probe) -> None:
# UNION (2) / INTERSECT (3) decode at Cobalt (the enum widened to 4 variants) and reach the logic,
# which rejects them with IncompatiblePolicyType rather than a decode failure or Panic. Both simple
# constructors share the guard (after the zero-admin check, before the batch-size guard); composites
# are minted only via createCompositePolicy. Well-formed ABI, so build it with the canonical encoder
# (a non-zero admin isolates the type check from the ZeroAddress path; an empty batch confirms the
# type check precedes the batch-size guard on the with-accounts path).
for policy_type in (UNION, INTERSECT):
create = _clean(c.policy, "createPolicy", c.DEPLOYER, policy_type)
c.expect_raw_revert(
f"createPolicy composite type {policy_type}", POLICY, create, error_name="IncompatiblePolicyType"
)
with_accounts = _clean(c.policy, "createPolicyWithAccounts", c.DEPLOYER, policy_type, [])
c.expect_raw_revert(
f"createPolicyWithAccounts composite type {policy_type}",
POLICY,
with_accounts,
error_name="IncompatiblePolicyType",
)


def _dirty_high_bits_rejected(c: Chain, _probe) -> None:
pid, acct = config.ALWAYS_BLOCK_ID, c.BOB
sel = _selector("isAuthorized(uint64,address)")
Expand Down Expand Up @@ -201,6 +223,10 @@ def _create_gas_independent_of_prefunded_balance(c: Chain, _probe) -> None:
("empty calldata reverts (no implicit receive/fallback)", _empty_calldata_reverts),
("truncated args revert (strict ABI decode)", _truncated_args_revert),
("out-of-range enum reverts", _enum_out_of_range_reverts),
(
"createPolicy/createPolicyWithAccounts composite type reverts IncompatiblePolicyType",
_create_policy_composite_type_reverts,
),
("dirty high bits rejected (strict ABI decode)", _dirty_high_bits_rejected),
("STATICCALL read-only enforced", _staticcall_read_only),
("value forwarding rejected through a contract", _value_forwarding_rejected),
Expand Down
Loading