[ENG-46310] feat(webkit): add Chip (inputs)#659
Closed
HerbertJulio wants to merge 1 commit into
Closed
Conversation
HerbertJulio
force-pushed
the
feat/ENG-46310-inputs-chips
branch
from
f719464 to
c0c7426
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // already wrapped in <template>) — unwrap once, then wrap in a runnable SFC. | ||
| transform: (code) => { | ||
| let src = String(code).trim() | ||
| if (/<script[\s>]/.test(src)) return src |
Contributor
Author
|
Substituído pelo #664 (na verdade ver link acima), refeito a partir da |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-46310
Adds the Chip component (
inputs/chips), following the Figma Chip set (node476:948) and our spec-driven pipeline. Aligns with how.specs/table.mdalready consumes it (<Chip :label removable @remove />, e.g. the data table's#filtersslot).API
label(fallback text for the default slot),size(small | medium),removable(renders a trailing × button).remove— emitted whenremovableand the × is activated.default(falls back tolabel).data-*variants (no JS class presets, no<style>); tokens mapped toDESIGN.md(--bg-surface-raised,--border-default,--shape-elements, label typography). The × is a real<button aria-label="Remove">with a visible focus ring; the chip root is a non-interactive container.Stories
Default,Sizes(small/medium),Removable(wiresremoveto the Actions panel) — with the "Show code" copy-paste-ready panel (runnable SFC, shown by default).Checks
pnpm --filter webkit lint✓ ·type-coverage100% ✓. Write-time hooks (tokens / references / spec-compliance) passed. (type-check/build:dtssurface only the unrelated pre-existingnavigation-menu-popup.vueerror already present onmain; the Chip itself is dts-valid.)