feat: add input-number component#654
Merged
Merged
Conversation
Spec-driven monolithic input for numeric values (counts, quantities, ports, thresholds) with small/medium/large sizes, configurable min/max/step, optional spinner column, prefix/suffix slots, and a lock indicator in the disabled state. Visual states (hover/focus-within/invalid/required/disabled) match the input-text v2 pattern: border-color hover gated by :not(:focus-within), focus-within ring with offset, --danger-border for invalid, --warning-border for required. modelValue is always numeric — clearing the native input falls back to min ?? 0. Adds Event/HTMLInputElement to the shared eslint globals so future components using native DOM types lint clean.
pauloSF0
previously approved these changes
Jun 24, 2026
robsongajunior
requested changes
Jun 26, 2026
robsongajunior
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputs/input-number: spec-driven monolithic numeric input with sizes (small/medium/large),min/max/step, optional spinner column,prefix/suffixslots, and a lock indicator in the disabled state.input-textv2 pattern: hover gated by:not(:focus-within),focus-withinring with offset,--danger-border/--warning-borderfor invalid/required.<input type=\"number\">under the hood —modelValueis always numeric; clearing the input falls back tomin ?? 0.v-modelbound), with hand-written code snippets for the Show code panel (same convention asfeat/inputs-select).EventandHTMLInputElementto the shared ESLint globals so components using native DOM types lint clean.Test plan
pnpm webkit:lintpassespnpm --filter storybook buildsucceedsmin/max/stepclampv-modelTabfocuses,↑/↓increment/decrement,Entercommits and fireschangeInputNumberat node3714:10789) across hover/focus/filled/invalid/required/disabled × 3 sizes