Add canvas-style node preview to the style dialog#1935
Merged
Conversation
The node style dialog now shows a prominent live preview of the node with its type label, matching the graph canvas rendering. The preview sits alongside the shape and icon controls in a bordered container with the same background as the graph/schema views. Also refactors IconPicker to accept children as its trigger element, giving callers control over the button appearance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The node style dialog showed a tiny inline preview that was easy to miss (#1907). Now there's a prominent live preview with the node's type label rendered exactly as it appears on the canvas — dark pill background, white text — so users can see the effect of style changes at a glance.
Also refactors IconPicker to accept
childrenas its trigger element, giving callers control over the button appearance.How to read
childrenas the trigger element instead of hardcoding the buttonchildrenpropValidation
Open the node style dialog (Nodes Styling panel → click the customize button on any node type). The preview should render a large node with the type label below it in a dark pill, updating live as you change shape, icon, color, or border settings.
Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.