Add drift-guard test for VertexSymbol visual field coverage#1933
Closed
kmcginnes wants to merge 1 commit into
Closed
Add drift-guard test for VertexSymbol visual field coverage#1933kmcginnes wants to merge 1 commit into
kmcginnes wants to merge 1 commit into
Conversation
6 tasks
Exhaustive destructuring in pickVisual() with a rest-must-be-empty satisfies check. Adding a field to VertexVisualStyle without listing it in the destructure is a compile error — no sidecar files or runtime test needed.
kmcginnes
force-pushed
the
drift-guard-test
branch
from
8475baf to
ba78c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test that fails when a field is added to
VertexVisualStylebut not consumed by theVertexSymbolpreview component or explicitly excluded with justification.Two layers enforce this:
satisfies Record<keyof VertexVisualStyle, true>check on the exhaustive key record. Adding a field to the type without listing it here is a type error.CONSUMED ∪ EXCLUDED = ALL_VISUAL_FIELDS, so even if someone skips the type check, CI catches it.How to read
visualFields.ts— the field sets and their compile-time guardsvisualFields.test.ts— the three runtime assertions (exhaustiveness, no overlap, no phantoms)