Move auth scheme/endpoint resolution from interceptor to pipeline stages#7017
Open
S-Saranya1 wants to merge 13 commits into
Open
Move auth scheme/endpoint resolution from interceptor to pipeline stages#7017S-Saranya1 wants to merge 13 commits into
S-Saranya1 wants to merge 13 commits into
Conversation
* Move auth scheme identity resolution to pipeline stage from interceptors * Address PR feedback: Added callback pattern for auth scheme options resolution Removed duplicate code Added fixture tests * Address Review comments: Move AuthSchemeResolutionStage to run before ApplyUserAgentStage and recording business metrics Simplify DefaultS3Presigner to use generated endpoint params * Remove identity provider override test from AwsExecutionContextBuilderTest, now happening in AuthSchemeResolutionStage
* Fix EndpointResolutionStage NPE on null port and preserve interceptor-set AWS_CREDENTIALS during auth scheme resolution
…f reading SELECTED_AUTH_SCHEME (#6930) * Update presign interceptors to resolve auth scheme directly instead of reading SELECTED_AUTH_SCHEME
… migration (#6955) * Update S3 and S3Control tests for auth scheme and endpoint resolution pipeline migration
…ration (#6947) * Fix S3Express utils and tests for auth scheme resolution pipeline migration
…line stage migration (#6965)
…point resolution (#6961) * Preserve interceptor-set signer properties across auth scheme and endpoint resolution * Fix benchmark imports after merging from master * Fix test failures after master merge * Update codegen fixture files * Address review comments
* Update codegen fixture files * Fix test failure * Fix test failure * Fix test failures * Fix checkstyle * Fix S3Express WireMock tests
…nterceptors (#7012) * Skip auth scheme and endpoint resolution if already resolved by old interceptors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License