fix: Only treat frozen Numeric defaults as immutable - #160
Open
jterapin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
The
_immutable?fast path added in #159 usedvalue.is_a?(Numeric), which matches anyNumericsubclass. A mutable customNumericsubclass used as adefault_valuewas therefore returned by identity and shared across every record in the process, so mutating it on one record leaked into the others.This guards the numeric branch with
frozen?: only genuinely immutable numerics skip the deep copy. Every stdlib numeric is already frozen, so they stay on the fast path and the #159 optimization is preserved; an unfrozen mutable subclass falls back to the existing deep copy.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Written with AI assistance and reviewed by jterapin