[Test] Fix race condition in test_build_image caused by export-image-logs and facilitate troubleshooting#7487
Merged
gmarciani merged 1 commit intoJul 15, 2026
Conversation
07778ef to
39c5f3c
Compare
…logs and facilitate troubleshooting.
39c5f3c to
0bc03d9
Compare
hanwen-cluster
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix race condition in test_build_image caused by export-image-logs
PR #7486 traded one race for another.
It fixed export-image-logs running too late, when the log group has already been deleted as part of a successful
build-image teardown, by moving the export earlier. But it then ran too early: it only waited for the build log stream to exist, however the log stream must contain some events for the export task to produce something.
The fix waits for the build log stream to be non-empty, not just to exist, before exporting, so the log data is ready to be exported.
Also set explicit messages on the soft assertions used by the test to ease troubleshooting.
Tests
SUCCESS
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.