[Test] Fix export-image-logs race by exporting while stack still exists#7484
Merged
gmarciani merged 1 commit intoJul 13, 2026
Conversation
In test_build_image, export logs as soon as the build log stream is available (while BUILD_IN_PROGRESS) so the build-image stack is guaranteed to exist, instead of after BUILD_COMPLETE when it self-deletes. Also validate export from a failed build, whose stack and log stream are retained.
48f1618 to
b45185d
Compare
hanwen-cluster
approved these changes
Jul 13, 2026
Contributor
|
✅ Cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix export-image-logs race by exporting while stack still exists
In test_build_image, export logs as soon as the build log stream is available (while BUILD_IN_PROGRESS) so the build-image stack is guaranteed to exist, instead of after BUILD_COMPLETE when it self-deletes.
Also validate export from a failed build, whose stack and log stream are retained.
Notice that we already export image logs if the image fails in test_build_image to capture logs for troubleshooting. However we do not assert on that command to succeed. That's the reason why we added the assertion on test
test_build_image_wrong_pcluster_versionTests
SUCCESS (Same test [params that reported the failure)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.