ci: fast CI#207
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Why don't we add support for |
|
that's a good catch! adding it now! |
| run: DISTRO=alpine make test-integ | ||
| - name: Run integration test (alpine ${{ matrix.distro_version }} / python ${{ matrix.runtime_version }}) | ||
| run: | | ||
| docker build -t codebuild-agent - < tests/integration/codebuild-local/Dockerfile.agent |
There was a problem hiding this comment.
This is repeated across all jobs, having it in a common job would reduce time further
There was a problem hiding this comment.
true, but this is going away with #208 so if that looks good to you let's merge both?
| @@ -18,8 +18,9 @@ def setUp(self): | |||
| self.socket = "/tmp/sock" | |||
|
|
|||
| def test_success_and_failure_isolation(self): | |||
There was a problem hiding this comment.
I think this test needs to be updated to reflect what are actually checking, using fork explicitly hides what's actually being used, so in the context of python 3.14 we force the test to use fork while we know the default now is to use forkserver. I'd use multiprocessing.Manager to track the shared data and this way we won't need to force usage of fork
| ), patch( | ||
| "awslambdaric.lambda_multi_concurrent_utils.multiprocessing.Process", | ||
| threading.Thread, |
There was a problem hiding this comment.
What i meant is that we should mock this at all, and rely on multiprocessing manager to track shared data, so here we're testing something different
There was a problem hiding this comment.
I see, I've changed back to no mock, but I still needed to add set_start_method as the default behaviour changed in python 3.14 (see: https://docs.python.org/3.14/whatsnew/3.14.html#concurrent-futures + python/cpython#84559)
fix: removing codebuild
5 participants
Description of changes:
sequentially via make test-integ
Add explicit permissions: contents: read to the workflow
available ones (alpine 3.21, debian bookworm)
test_success_and_failure_isolationon Python 3.14 by using explicit fork multiprocessing context (3.14 changeddefault start method to forkserver)
Target (OCI, Managed Runtime, both):
both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.