feat(schema): add ap-south-2 (HYD) and us-west-1 (SFO) to region allowlist - #2132
feat(schema): add ap-south-2 (HYD) and us-west-1 (SFO) to region allowlist#2132jariy17 wants to merge 1 commit into
Conversation
…wlist Enable AgentCore CLI in the new launch regions. Extends AgentCoreRegionSchema and the llm-compacted type union; updates the negative-region assertion since us-west-1 is now valid.
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Package TarballHow to installgh release download pr-2132-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.0.tgz |
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped data change. The zod enum in src/schema/schemas/aws-targets.ts, the read-only mirror in src/schema/llm-compacted/aws-targets.ts, and the test in src/schema/schemas/__tests__/aws-targets.test.ts are all updated in lockstep, and the rejection case was properly swapped from us-west-1 to me-central-1. No telemetry or mocking concerns apply here.
One non-blocking sanity check for the author: the AWS regional services table (api.regional-table.region-services.aws.a2z.com/index.json) currently lists Amazon Bedrock AgentCore in 20 regions, and neither us-west-1 nor ap-south-2 are in that set. The file comment says to keep this list in sync with the AgentCore regions doc — please confirm these two regions are actually launched/supported for AgentCore before merging (or link to the internal source of truth in the PR description). If you have internal confirmation this is a coming/just-launched expansion, ignore this.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
Coverage Report
|
1 participant
What
Add
ap-south-2(HYD) andus-west-1(SFO) to the AgentCore region allowlist so the CLI accepts these launch regions invalidate/deployand the TUI region picker. The other four launch regions (ap-southeast-7, ap-southeast-5, eu-south-1, eu-south-2) are already present.Why
AgentCoreRegionSchemais the front-door validation for deployment-target regions. Without these two entries the CLI rejects HYD/SFO before deploy. The partition/ARN/endpoint layer (src/cli/aws/partition.ts) is already region-agnostic (SDK-derived) and needs no change.Must land with the CDK counterpart — aws/agentcore-l3-cdk-constructs#343 — which gates synth on the same enum.
Changes (per AGENTS.md "Adding a New Region")
src/schema/schemas/aws-targets.ts—AgentCoreRegionSchemaenum +2src/schema/llm-compacted/aws-targets.ts—AgentCoreRegiontype union +2 (kept in sync)src/schema/schemas/__tests__/aws-targets.test.ts— options list +2; updated the negative assertion (us-west-1is now valid → usesme-central-1)BEDROCK_REGIONS(Bedrock Agent import only) intentionally unchanged — separate scope from AgentCore deployment regions.Verification
npm run test:unit— 429 files / 6153 tests pass; typecheck + build passagentcore validateon real configs: all 6 launch regions pass; unsupported control (me-central-1) correctly rejectedagentcore deployto a CloudFormation stack (us-west-2, patched CLI) verified end to end