fix: make esbuild available at runtime - #2126
Open
Ryuta1005 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeScript CodeZip packaging invokes esbuild at runtime. However, the CLI build bundles esbuild's JavaScript API, causing
agentcore packageto fail with:This PR:
esbuildto the CLI build'sexternallist.esbuildfromdevDependenciestodependenciesand updatesnpm-shrinkwrap.jsonwithout changing the version range.TestRuntime.zipis generated.Both dependency changes are necessary: externalizing esbuild prevents it from being bundled into the CLI, while declaring it as a production dependency makes it available after installation.
The existing global tarball installation step is unchanged. The fixture has no application dependencies and exists only to exercise TypeScript packaging.
Related Issue
Closes #2125
Documentation PR
N/A — this fixes package distribution without changing the public CLI interface.
Type of Change
Testing
Validation was performed on macOS with Node.js
v24.15.0.npm run test:unit— 428 test files passed; 6,150 tests passed.npm run test:integ— 34 test files passed; 342 tests passed and 1 test skipped.npm run typecheck— passed.npm run lint— completed with 0 errors and 32 warnings.src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots — N/A; no files undersrc/assets/were modified.All reported lint warnings are in files not modified by this PR. No additional lint warnings were observed compared with main.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.