feat(dev): supervise every runtime in project dev - #2041
Merged
Conversation
tejaskash
had a problem deploying
to
e2e-testing
August 19, 2026 19:12 — with
GitHub Actions
Failure
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 19, 2026 19:51
1864da4 to
c539836
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37%
==========================================
Files 424 425 +1
Lines 25571 25761 +190
==========================================
+ Hits 24897 25084 +187
- Misses 674 677 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 20, 2026 16:09
c539836 to
6080aa0
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 20, 2026 16:18
6080aa0 to
82af18a
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 21, 2026 15:23
82af18a to
2db7743
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 21, 2026 16:14
2db7743 to
136a454
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 21, 2026 17:51
136a454 to
35775f9
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 21, 2026 18:55
35775f9 to
a9f11fe
Compare
tejaskash
force-pushed
the
feat/dev-supervisor
branch
2 times, most recently
from
August 24, 2026 16:13
7b4b60b to
0ca91f0
Compare
Contributor
Is this the behavior on the publicly released CLI? I thought we always had to select one? |
tejaskash
force-pushed
the
feat/dev-supervisor
branch
2 times, most recently
from
August 24, 2026 21:51
fc5db62 to
9904ee1
Compare
notgitika
self-requested a review
August 24, 2026 22:14
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 25, 2026 15:06
9904ee1 to
0a77c0c
Compare
The #1980 rebase carried a single-runtime host check (runtime.build) into the multi-agent dev handler, where the variable is the runtimes array. Bind all interfaces when any selected runtime runs in a container.
…batch events() spliced the queue, yielded each event, then installed its wake callback and blocked. A push landing during the yields ran while wake was undefined, so its wake was a no-op, and the newly installed waiter never noticed the queued event until the next push or shutdown. Re-check the queue inside the wait so a queued event resolves immediately.
tejaskash
force-pushed
the
feat/dev-supervisor
branch
from
August 25, 2026 19:39
175d896 to
abf8c23
Compare
…s review Remove the runSingleRuntime special case so every runtime, one or many, runs through DevSupervisor. Start all agents concurrently and stream their output live rather than awaiting each readiness first. End the event loop when no agent is starting or running, and exit non-zero when none started. Make start() async so an unknown name rejects rather than throwing synchronously. Time readiness off the agent's last output (idle timeout) so a slow build that keeps logging is not killed. Move waitForPort into src/io/port.ts to keep socket IO in the IO layer. Rename the environment accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Split renderEvent into renderAgentEvent (agent name required) and renderStatus for command-level trace-collector lines, so agent output is always tagged with [name] and the agent-optional branches are gone. Addresses review feedback on #2041.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
jariy17
approved these changes
Aug 25, 2026
notgitika
approved these changes
Aug 25, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review after #1980
What this does
agentcore project devwithout--agentruns all of the project's runtimes at once. Each agent's output is attributed ([orders] ...in the terminal, anagentfield in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.How
DevSupervisor(core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.Verification
agentcore.json, ranproject dev— both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtimeOTEL_SERVICE_NAMEverified end to end). SIGTERM exits 130.tsc/lint/format clean.