Remove overwrite of Notice from code-generator - #729
Conversation
|
/test pipes-controller-test |
|
/test dynamodb-controller-test |
|
/retest |
| cp "$ROOT_DIR"/CONTRIBUTING.md "$SERVICE_CONTROLLER_SOURCE_PATH"/CONTRIBUTING.md | ||
| cp "$ROOT_DIR"/GOVERNANCE.md "$SERVICE_CONTROLLER_SOURCE_PATH"/GOVERNANCE.md | ||
| cp "$ROOT_DIR"/LICENSE "$SERVICE_CONTROLLER_SOURCE_PATH"/LICENSE | ||
| cp "$ROOT_DIR"/NOTICE "$SERVICE_CONTROLLER_SOURCE_PATH"/NOTICE |
There was a problem hiding this comment.
if we wanted to be nitty, could skip copy only if the file already exists... but i think this is fine.
There was a problem hiding this comment.
We do already populate the Notice with the controller-bootstrap tool. So, it should already exist once the repo is setup.
https://github.com/aws-controllers-k8s/controller-bootstrap/blob/main/templates/NOTICE.tpl
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlbutler, knottnt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #, if available:
Description of changes:
In some cases contributors may add their own entries the service controller's NOTICE file. This PR updates the code-generator's build-controller.sh script to no longer overwrite those additions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.