fix: upgrade Go to 1.25.11 and x/net to resolve stdlib vulnerabilities#31
Merged
Conversation
…lnerabilities govulncheck fails CI on main: GO-2026-5037 (crypto/x509), GO-2026-4971 (net), GO-2026-4918 (net/http + golang.org/x/net) are reachable from keystore key generation, wallet dialing, and network ID lookup. All are fixed in go1.25.10/1.25.11 and x/net v0.53.0. - go.mod: go 1.25.9 -> 1.25.11; x/net v0.47.0 -> v0.53.0 (pulls x/crypto, x/sys, x/term, x/text et al. forward) - ci.yml: bump setup-go and GOTOOLCHAIN pins to 1.25.11 govulncheck now reports 0 reachable vulnerabilities.
owenwahlgren
requested review from
containerman17 and
martineckardt
as code owners
federiconardelli7
approved these changes
Jun 10, 2026
martineckardt
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's govulncheck step currently fails on main itself (surfaced on #29/#30): four reachable stdlib vulnerabilities in Go 1.25.9 plus golang.org/x/net v0.47.0:
keystore.GenerateKeywallet.NewFullWalletFromKeychainnetwork.GetNetworkIDThis also covers the open Dependabot alerts on the default branch.
Changes
go.mod:go 1.25.9→1.25.11;golang.org/x/net v0.47.0→v0.53.0(pulls x/crypto, x/sys, x/term, x/text, x/tools forward).github/workflows/ci.yml:setup-goand allGOTOOLCHAINpins → 1.25.11Validation
govulncheck ./...→ 0 reachable vulnerabilitiesgo build,go vet, staticcheck v0.6.1,go test -race ./pkg/... ./cmd/...all pass on go1.25.11Note: this commit is cherry-picked onto #29 and #30 so their CI goes green without waiting; the identical patches dedupe at merge time. Merge this one first if convenient.