ci(sap-e2e): upload the run bundle flowproof already writes - #481
Open
HappyDevs1 wants to merge 1 commit into
Open
ci(sap-e2e): upload the run bundle flowproof already writes#481HappyDevs1 wants to merge 1 commit into
HappyDevs1 wants to merge 1 commit into
Conversation
The nightly sap-e2e job has failed every cron-triggered run since 2026-07-31 (a manual dispatch outside that window passes cleanly, which points at a nightly SAP-side maintenance/batch window rather than a flowproof regression). Diagnosing it required inferring from console text alone: flowproof run already captures per-step PNG frames and a report.html into the suite's run dir on every invocation (recording-detail defaults to full), but the workflow never kept that bundle past the job, so the actual failing screens were never available to look at. Upload examples/sap/.flowproof/runs/ as a build artifact, unconditionally, so the next failure comes with the frames instead of a guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sap-e2ejob has failed every cron-triggered run since 2026-07-31 (15/15). A manualworkflow_dispatchrun outside that window passed cleanly, all four flows green — which points at a nightly SAP-side maintenance/batch window colliding with the0 3 * * *schedule, not a flowproof regression.flowproof runalready writes per-step PNG frames andreport.htmlinto the suite's run directory on every invocation (--recording-detaildefaults tofull) — the workflow just never kept that bundle past the job, so the actual failing SAP screens were never available to look at.actions/upload-artifact@v4step,if: always(), pointed atexamples/sap/.flowproof/runs/— no application code changes. Retention is set short (14 days) since the frames are real screens off the reference SAP system and may show live order/material data.Test plan
sap-e2e.ymlYAML validated locally (python3 -c "import yaml; yaml.safe_load(...)")sapself-hosted runner uploads asap-e2e-run-<run_id>artifact containingreport.json/report.html/ frame PNGs, including on failure🤖 Generated with Claude Code