test(sap): add complex sales order audit - #467
Open
HappyDevs1 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a long, read-only SAP GUI “audit” flow + recorded trace, and hardens the SAP COM adapter’s notion of “surface text”/“scene” so hidden menu items and background windows can’t satisfy assertions while a modal is active.
Changes:
- Added a new 81-step VA03 sales-order lifecycle audit flow (
audit-sales-order.flow.yaml) and its cassette (audit-sales-order.trace.jsonl). - Updated
SapAppDriversurface text and scene generation to (a) ignoreGuiMenuitems and (b) scope output to the highest activewnd[n]to avoid false positives. - Added focused adapter tests covering menu exclusion/prioritization and modal-vs-background window behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/sap/audit-sales-order.trace.jsonl | New recorded SAP trace for the 81-step audit scenario. |
| examples/sap/audit-sales-order.flow.yaml | New deterministic, read-only audit flow definition for VA03 sales-order lifecycle checks. |
| crates/flowproof-adapters/src/sap_com.rs | Filters surface/scene to the active window and deprioritizes/excludes closed menu hierarchy; adds regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+10
| name: Audit sales order lifecycle | ||
| app: sap | ||
| steps: |
| @@ -0,0 +1,82 @@ | |||
| {"format":"flowproof-trace","version":1,"trace_id":"2fdeacb6-406d-4229-842a-d531b4433d3e","recorded_at":"2026-08-11T09:34:25Z","spec":{"name":"Audit sales order lifecycle"},"app":{"name":"sap","adapter":"sap-com","window_title":"SAP"},"env":{"os":"windows","resolution":[1920,1080]},"recording":{"format":"filmstrip/1","dir":".flowproof/recordings/2fdeacb6-406d-4229-842a-d531b4433d3e/recording"}} | |||
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety
The flow contains no Save, Change, Create, Delete, profile, configuration, or administration steps. It finishes by returning SAP to Easy Access.
Verification
Focused clippy is currently blocked by an unrelated existing warning in
flowproof-driver/src/window.rs:180under Rust 1.97.