test: fix tests for windows - #714
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
miparnisari
force-pushed
the
windows-support
branch
from
August 7, 2026 18:18
d3d03cc to
c3c9a31
Compare
miparnisari
force-pushed
the
windows-support
branch
from
August 7, 2026 18:27
c3c9a31 to
9e16d6b
Compare
miparnisari
marked this pull request as ready for review
August 7, 2026 18:32
tstirrat15
approved these changes
Aug 7, 2026
Comment on lines
+52
to
+53
| unixNotExistPattern = regexp.MustCompile(`no\s+such\s+file\s+or\s+directory`) | ||
| windowsNotExistPattern = regexp.MustCompile(`The\s+system\s+cannot\s+find\s+the\s+file\s+specified\.`) |
Contributor
There was a problem hiding this comment.
Another potential approach here is to use runtime.GOOS == "windows" and then have separate test paths. I think it's fine as is if you don't feel like doing that.
Comment on lines
+3
to
+7
| # Schema/validation-file fixtures are parsed byte-for-byte (schema DSL error | ||
| # messages report line/column position), and several tests compare their | ||
| # contents against hardcoded LF string literals. Without this, Windows | ||
| # checkouts with core.autocrlf=true would convert them to CRLF and break | ||
| # both the comparisons and the reported positions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBulkDeleteForcingandTestBulkDeleteManyForcingare flaky #512 thanks to bringing fix: Handle concurrent MemDB writes spicedb#3239