Skip to content

chore: drop JDK 8 from integration test matrix#172

Merged
tstirrat15 merged 2 commits into
mainfrom
fix/drop-jdk8-from-test-matrix
May 26, 2026
Merged

chore: drop JDK 8 from integration test matrix#172
tstirrat15 merged 2 commits into
mainfrom
fix/drop-jdk8-from-test-matrix

Conversation

@vroldanbet
Copy link
Copy Markdown
Contributor

@vroldanbet vroldanbet commented May 26, 2026

Summary

  • Remove - 8 # Oldest from the test matrix in .github/workflows/build.yaml.
  • Fixes the Java 8 Test job that's been failing since the Gradle 9.3.1 wrapper bump in 91809c3.

Why

Gradle 9.x dropped JDK 8 support for running the Gradle daemon, so the Java 8 Test job fails immediately with:

Gradle requires JVM 17 or later to run. Your build is currently configured to use JVM 8.

The library's bytecode target also moved to JDK 17 in 452e52d chore: fix gradle warnings (sourceCompatibility/targetCompatibility = VERSION_17), so the artifact can't run on JDK 8 at runtime either. The matrix entry is dead weight that just turns every PR red.

Failing run: https://github.com/authzed/authzed-java/actions/runs/26462262774/job/77913010022

The build matrix is already JDK 17 / 21 / 25 — no JDK 8 there to remove.

Test plan

  • PR's own CI passes (Java 21 Test, Java 24 Test, all three Build jobs).

@vroldanbet
chore: drop JDK 8 from integration test matrix
99546c3 
The Gradle 9.3.1 bump in 91809c3 requires JDK 17+ to run the Gradle
daemon, so the JDK 8 test job now fails immediately with "Gradle
requires JVM 17 or later to run." The library itself also moved to
sourceCompatibility/targetCompatibility 17 in 452e52d, so JDK 8 is
no longer a runtime target.
@vroldanbet vroldanbet marked this pull request as ready for review May 26, 2026 16:58
@vroldanbet vroldanbet requested a review from a team as a code owner May 26, 2026 16:58
@vroldanbet vroldanbet self-assigned this May 26, 2026
@vroldanbet
chore: mirror test matrix to build matrix (JDK 17, 21, 25)
ebb4eb6 
Adds JDK 17 and replaces JDK 24 with JDK 25 so the test matrix lines
up with the build matrix.
tstirrat15
tstirrat15 approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit 58d7ade May 26, 2026
9 checks passed
@tstirrat15 tstirrat15 deleted the fix/drop-jdk8-from-test-matrix branch May 26, 2026 17:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees

@vroldanbet vroldanbet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vroldanbet @tstirrat15