fix: resolve dry-run reporting bugs across multiple asset types - #1462
Open
ankita10119 wants to merge 6 commits into
Open
fix: resolve dry-run reporting bugs across multiple asset types#1462ankita10119 wants to merge 6 commits into
ankita10119 wants to merge 6 commits into
Conversation
…s, and included-connections
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
- Coverage 80.51% 80.51% -0.01%
==========================================
Files 163 163
Lines 7745 7749 +4
Branches 1721 1723 +2
==========================================
+ Hits 6236 6239 +3
Misses 808 808
- Partials 701 702 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harshithRai
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR fixes 5 dry-run bugs affecting accuracy and reliability of a0deploy import --dry-run output:
!/\[\d+\]/g/was suppressing every diff message whose path contained an array index.[object Object]when an object array item had no counterpart on the other side, because template literal interpolation was used directly on an object value.AUTH0_IGNORE_DRY_RUN_FIELDSconfig had no effect on databases. The databases handler passedthis.ignoreDryRunFields(constructor-only) instead ofthis.getEffectiveIgnoreDryRunFields()(config-merged).AUTH0_INCLUDED_CONNECTIONS.getType()returns null (e.g. 403 or empty tenant), wrapping it in [null] caused downstream crashes. Guard changed toexisting ? [existing] : [].📚 References
🔬 Testing
Manual E2E -
a0deploy import --dry-runagainst a live tenant:connections[0].assign_membership_on_login: false → true. Dry-run correctly reported the org asUPDATE. Before the fix, no UPDATE was reported.getObjectDifferencesoutput with a local array longer than remote. Message showslocal:{"flag":2,"name":"b"} vs remote:undefined- no[object Object].AUTH0_INCLUDED_CONNECTIONS: ["google-oauth2"], onlygoogle-oauth2.jsonin input, 8 connections on tenant. Result:No changes detected- zero phantom DELETEs for the 7 excluded connections."AUTH0_IGNORE_DRY_RUN_FIELDS": {"databases": ["enabled_clients"]}. Database UPDATE count dropped from 5 to 1 -enabled_clientsnoise correctly suppressed.existingisnull📝 Checklist