Skip to content

Fix Primitve Array Logging #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cp1362 wants to merge 1 commit into
base: att/4.22.0.0
Choose a base branch
from
Open

Fix Primitve Array Logging #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private byte[] validateAndDecodeByHTTPMethod(String userData, int maxHTTPLength,
throw new InvalidParameterValueException("User data is too short.");
}

logger.trace(String.format("Decoded user data: [%s].", decodedUserData));
logger.trace(String.format("Decoded user data: [%s].", new String(decodedUserData)));
int userDataLength = userData.length();
int decodedUserDataLength = decodedUserData.length;
logger.info(String.format("Configured base64 encoded user data size: %d bytes, actual user data size: %d bytes", userDataLength, decodedUserDataLength));
Expand Down
2 changes: 1 addition & 1 deletion ...rvisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5788,7 +5788,7 @@ public List<Ternary<String, Boolean, String>> cleanVMSnapshotMetadata(Domain dm)
}
for (String snapshotName: snapshotNames) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug(String.format("Cleaning snapshot [%s] of VM [%s] metadata.", snapshotNames, dm.getName()));
LOGGER.debug(String.format("Cleaning snapshot [%s] of VM [%s] metadata.", snapshotName, dm.getName()));
}
DomainSnapshot snapshot = dm.snapshotLookupByName(snapshotName);
snapshot.delete(flags); // clean metadata of vm snapshot
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/api/ApiServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ public String handleRequest(final Map params, final String responseType, final S
logger.info(ex.getDescription());
throw ex;
} catch (final Exception ex) {
logger.error("unhandled exception executing api command: " + ((command == null) ? "null" : command), ex);
logger.error("unhandled exception executing api command: " + ((command == null || command.length == 0) ? "null" : command[0]), ex);
String errorMsg = ex.getMessage();
if (!accountMgr.isRootAdmin(CallContext.current().getCallingAccount().getId())) {
// hide internal details to non-admin user for security reason
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/storage/StorageManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2887,7 +2887,7 @@ public boolean checkIfHostAndStoragePoolHasCommonStorageAccessGroups(Host host,
}

if (ArrayUtils.isNotEmpty(hostStorageAccessGroups)) {
logger.debug(String.format("Storage access groups on the host %s are %s", host, hostStorageAccessGroups));
logger.debug(String.format("Storage access groups on the host %s are %s", host, Arrays.toString(hostStorageAccessGroups)));
}

if (CollectionUtils.isNotEmpty(storagePoolAccessGroups)) {
Expand Down