Show live previews during local video renders - #4816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4588
Summary
preview.pngfrom supported LTX and MiniMax H3 MLX runner stepscurrentImageTest plan
cd server && npm test -- services/videoGen/local.test.js ../scripts/generate_ltx2.test.js ../scripts/generate_minimax_h3.test.js ../scripts/_runner_common.test.jspython3 scripts/_runner_common_test.pypython3 -m py_compile scripts/_runner_common.py scripts/generate_ltx2.py scripts/generate_minimax_h3.pynode --check server/services/videoGen/local.jscd server && npm test— 1,565 files passed, 32,819 tests passedpreview.pngThe full MiniMax H3 render was not run because its pinned model snapshot is not cached on this machine and the CUDA runtime is not installed; the H3 runner projection path is covered by focused tests.