surface linked FableLoom branching narratives inside series management - #4810
Merged
Conversation
#4785) A loom stays its own record — no `seriesType: 'branching'` enum on `pipeline_series`, no schema-version bump — so the integration lands at the presentation/cross-linking layer instead, the same posture as Games and Creative Director: - `GET /api/fableloom?seriesId=` scopes the index to one series' looms. A blank value is a no-op filter rather than a 400, so a caller can build the query from a possibly-unset id. - The series detail page gains a "Branching narratives" card listing those looms with their episode/scene/ending counts, plus a "New branching narrative" action that mints one pre-linked to the series and its universe and lands in the editor. - The series index badges each row with its loom count. - The loom editor header gains a series backlink. Both directions stay soft refs: deleting a series is never blocked, and a dangling `seriesId` renders no chip rather than a dead link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces FableLoom looms inside series management at the presentation/cross-linking layer. Per the issue's decision, a loom stays its own record — no
seriesType: 'branching'enum onpipeline_series, nopipeline_seriesschema change, no schema-version bump.GET /api/fableloom?seriesId=scopes the index to one series' looms (loomListQuerySchemainserver/lib/fableLoomValidation.js, filtering inlistLoomSummaries). A blank value is a no-op filter rather than a 400, so a caller can build the query from a possibly-unset id; a dangling id matches nothing instead of throwing.SeriesLoomsPanel) listing linked looms with their episode/scene/ending counts and a link into/fableloom/:loomId— mirroring howCatalogCastPanelsurfaces linked catalog records.seriesIdrenders no chip rather than a dead link.Test plan
cd server && npm test— full suite green (32,759 passed). New coverage:listLoomSummariesseries scoping + dangling-id case (services/fableLoom/records.test.js), and the route's filter / blank-value / over-long-id cases (routes/fableLoom.test.js).cd client && npm test— full suite green apart from two known load-related flakes (a11yConventionstimeout,Catalog.test.jsxact warning) that pass in isolation and are untouched by this branch. New suites:SeriesLoomsPanel.test.jsx,Pipeline.loomBadge.test.jsx,FableLoomStory.test.jsx(backlink present / deleted-series graceful / unnamed-series fallback / standalone), plusapiFableLoom.test.jsquery-encoding cases.cd client && npm run lint— clean.Closes #4785