Add OptionAcronymList and LoadAcronymsFromFile helpers#58
Conversation
This commit introduces `OptionAcronymList` and `LoadAcronymsFromFile` in the root `strings2` package to provide easy ways for configuring acronym mapping without boilerplate. `OptionAcronymList` takes a slice of strings and returns a `WordMapper` that maps matching words to `AcronymWord`. `LoadAcronymsFromFile` reads a file line-by-line to extract acronyms. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d93ce51199
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5be0540e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Since it's in example use Must[T](T, error) T |
| dir, _ := os.MkdirTemp("", "acronyms") | ||
| defer os.RemoveAll(dir) | ||
| file := filepath.Join(dir, "acronyms.txt") | ||
| os.WriteFile(file, []byte("HTTP\nJSON\n"), 0644) |
There was a problem hiding this comment.
@jules Error return value of os.WriteFile is not checked (errcheck)
1 participant
This PR introduces
OptionAcronymListandLoadAcronymsFromFilein thestrings2package to allow configuring acronym mapping easily from the root module without boilerplate code.PR created automatically by Jules for task 9477226251924272339 started by @arran4