SOAR-0015: Add namespace file splitting proposal - #930
Conversation
nac5504
changed the title
|
|
||
| - `output.types.fileSplitting.strategy`, currently supporting `namespace`. | ||
|
|
||
| The same model is used by YAML configuration, direct command-line invocation, and programmatic callers that construct `_OpenAPIGeneratorCore.Config` directly. |
There was a problem hiding this comment.
Please remove these implementation details. The design details should be about the conceptual approach and user-visible concepts.
There are many possible implementations, so no need to lock that in the proposal, in fact it can distract from where users should provide feedback - on the API and config file, not on the implementation.
|
|
||
| #### Build-tool plugin boundary | ||
|
|
||
| SwiftPM and Xcode build-tool plugins must declare generated output files before invoking the generator executable. PR #925 therefore rejects build-tool plugin invocations when `output.types.fileSplitting` is configured. |
There was a problem hiding this comment.
Hmm this is unfortunate - we should discuss more what our options are.
There was a problem hiding this comment.
Not being able to support this in the build plugin might actually be an argument for switching this to be the default and making this not even configurable. What do folks think?
There was a problem hiding this comment.
I think we should be open to moving to a prebuild plugin if it unlocks significant benefits. If we need a dynamic number of files generated then that's what prebuild plugins are advertised as the solution for.
simonjbeaumont
left a comment
simonjbeaumont
left a comment
There was a problem hiding this comment.
|
Great, thanks @nac5504 - I added my +1 on the forums thread. |
|
Here is the next feature I would like to land after this proposal concludes: nac5504#8. Any early feedback would be greatly appreciated! |
|
Hi all, (temporarily taking over as release manager due to Si's OOO). Thank you everyone for the feedback - it was broadly supportive, so this proposal is now Ready for Implementation. |
|
Thanks again @nac5504 - the proposal was accepted. I'll get this PR merged, and please tag @simonjbeaumont and me in the implementation PR once it's ready and fully aligned with the accepted proposal. |
3 participants
Summary
Types.swiftoutput.Notes
The proposal is scoped to the namespace split from PR #925:
Types.swift,Types+Components.swift, andTypes+Operations.swift,Types+Components+Schemas.swift, etc. More advanced sharding remains listed only as future direction.