Validate container ID from XPC requests#1956
Open
katiewasnothere wants to merge 2 commits into
Open
Conversation
Code Coverage
|
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
validate_xpc_containerid
branch
from
July 16, 2026 21:08
8ca584c to
12d7472
Compare
jglogan
requested changes
Jul 16, 2026
| /// Utility.validEntityName | ||
| /// Container name rule | ||
| public static func nameValid(_ name: String) -> Bool { | ||
| guard name.count < 63 else { |
Contributor
There was a problem hiding this comment.
Suggested change
| guard name.count < 63 else { | |
| // Maximum Linux hostname length is 64, but limit to maximum DNS label length | |
| guard name.count =< 63 else { |
Do we have a unit test that checks the length constraint?
katiewasnothere
force-pushed
the
validate_xpc_containerid
branch
from
July 16, 2026 21:51
9ec5fee to
2ec268f
Compare
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
validate_xpc_containerid
branch
from
July 17, 2026 18:53
2ec268f to
6e1c195
Compare
jglogan
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Validate XPC message provided container IDs in ContainersHarness to prevent file path traversal when container ID is invalid.
Testing