Skip to content

DUX-12033: Remove deprecated Bedrock InvokeModel protocol - #26

Merged
samuelboland merged 1 commit into
mainfrom
DUX-12033-audit-invokemodel-fork-usage-ruby-llm
Aug 10, 2026
Merged

DUX-12033: Remove deprecated Bedrock InvokeModel protocol#26
samuelboland merged 1 commit into
mainfrom
DUX-12033-audit-invokemodel-fork-usage-ruby-llm

Conversation

@staging-supernova-dx-appf-io

@staging-supernova-dx-appf-io staging-supernova-dx-appf-io Bot commented Aug 10, 2026

Copy link
Copy Markdown

What this does

Removes the unused Bedrock InvokeModel protocol implementation from ruby_llm. This protocol enabled access to Anthropic's beta features (context_management/server-side prompt caching) via the raw InvokeModel endpoint, but is no longer used in production across agents_app and agent_bridge. The feature was recently deprecated in favor of the standard Converse API which provides equivalent functionality.

Specifically removes:

  • BedrockInvokeModel protocol class and submodules (Chat and Streaming implementations)
  • All related test coverage for the InvokeModel endpoint
  • Configuration option for auto-injecting prompt-cache breakpoints
  • Protocol registration from the Bedrock provider

Maintains the appfolio/ruby_llm GitHub dependency and all other fork customizations—only the obsolete InvokeModel-specific code is removed.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Required for new features

N/A

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

AI-generated code

  • I used AI tools to help write this code
  • I have reviewed and understand all generated code (required if above is checked)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Agent session: https://staging.supernova.dx.appf.io/coders/628bd5a6-7f78-4b60-8b04-cd5a0fb0aa5b

@kermitapp

kermitapp Bot commented Aug 10, 2026

Copy link
Copy Markdown

@staging-supernova-dx-appf-io

Copy link
Copy Markdown
Author

🤖 Supernova Code Review — View trace

♻️ Re-run this automation

@staging-supernova-dx-appf-io staging-supernova-dx-appf-io Bot changed the title DUX-12033: Remove unused Bedrock InvokeModel protocol from ruby_llm DUX-12033: Remove unused Bedrock InvokeModel fork protocol from ruby_llm Aug 10, 2026

@staging-supernova-dx-appf-io staging-supernova-dx-appf-io Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this PR — it's a clean, self-contained removal of the unused Bedrock InvokeModel protocol. Verified no dangling references remain to BedrockInvokeModel, bedrock_use_invoke_model, invoke_model?, anthropic_beta, or anthropic_context_management anywhere else in the repo at this branch's head, and the comment updates in mantle_responses.rb and bedrock.rb correctly reflect the simplified routing (mantle vs. Converse only). No actionable bugs, security issues, or missing error handling found — no inline comments.

♻️ Re-run this automation

@staging-supernova-dx-appf-io staging-supernova-dx-appf-io Bot changed the title DUX-12033: Remove unused Bedrock InvokeModel fork protocol from ruby_llm DUX-12033: Remove deprecated Bedrock InvokeModel protocol Aug 10, 2026
Co-authored-by: Sam Boland <sam.boland@appfolio.com>
@staging-supernova-dx-appf-io
staging-supernova-dx-appf-io Bot force-pushed the DUX-12033-audit-invokemodel-fork-usage-ruby-llm branch from d5fb23d to 69f6181 Compare August 10, 2026 22:41
@samuelboland
samuelboland merged commit 5aaa408 into main Aug 10, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants