feat: read applyEnvVarsToBuild from actor.json in push (#734) - #1346
Draft
MatousMarik wants to merge 1 commit into
Draft
feat: read applyEnvVarsToBuild from actor.json in push (#734)#1346MatousMarik wants to merge 1 commit into
MatousMarik wants to merge 1 commit into
Conversation
The field persists the build env vars setting per repo, so it applies on every push without remembering the flag. The --apply-env-vars-to-build flag takes precedence over the field, and an explicit false in actor.json turns the setting off. When both are omitted, the value stored on the platform is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #734, stacked on #1345 (retarget to
masteronce that merges — only the last commit is new here).What
apify pushnow readsapplyEnvVarsToBuildfrom.actor/actor.json, so the setting persists per repo and applies on every push (useful for CI and Actors needing build-time secrets).--apply-env-vars-to-buildflag >applyEnvVarsToBuildin actor.json > omitted (value stored on the platform is kept). An explicitfalsein actor.json turns the setting off.docs/vars.md; flag description updated (+ regenerateddocs/reference.md).Tests
[api]test covering fieldtrue, fieldfalse, and flag-over-field precedence. Full push API suite passes (14/14), plustest:local, lint, format, build.useActorConfigcaches by cwd, so the test resets the cache when rewriting actor.json mid-test.Follow-up (separate PR)
--env KEY=VALUEpassing on push (the other half of Pass environment variables toapify pushand toggleapplyEnvVarsToBuild#734).No new dependencies; no install-size impact.