Rethrow createRelease error - #242
Merged
Merged
Conversation
Siegrift
requested changes
Jul 23, 2026
| console.info(`Unable to create Github release`); | ||
| console.info(goRes.error.message); | ||
| return null; | ||
| throw goRes.error; |
Collaborator
There was a problem hiding this comment.
Actually, now that I think about it - it's possible projects would not want to use the GH_ACCESS_TOKEN at all. I think for those it makes sense to use the previous behaviour.
I think a better way would be check whether the token exists and if yes (and the release failed) throw. Otherwise, just print the message.
Contributor
Author
There was a problem hiding this comment.
There's still this check above which I kept in:
if (!process.env.GH_ACCESS_TOKEN) {
console.info(`GH_ACCESS_TOKEN not set. Skipping release creation`);
return null;
}
Siegrift
approved these changes
Jul 23, 2026
Siegrift
left a comment
Siegrift
left a comment
Collaborator
There was a problem hiding this comment.
👍 LGTM (the check I didn't see from the GH diff and forgot about)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241