Remove dead ASR task and fix object-detection UI conditionals - #174
Open
Alvin-Nahabwe wants to merge 1 commit into
Open
Remove dead ASR task and fix object-detection UI conditionals#174Alvin-Nahabwe wants to merge 1 commit into
Alvin-Nahabwe wants to merge 1 commit into
Conversation
The ASR task was fully wired in the client but targets an API surface that no longer exists: there is no /train/asr endpoint, no `asr` key in the model registry, and no ASR inference script. Selecting ASR populated nothing and submitting failed. Removed the training panel, the inference panel, the checkpoint finder, the job submission, the result outputs, and the four dropdown entries. ASR now appears nowhere in the app. Two object-detection conditionals were also wrong: - RT-DETR is an Ultralytics model (the API routes it to the YOLO trainer via `is_ultralytics_model`), but the UI showed it the Transformers hyperparameters and hid the YOLO ones. Both panels now key off YOLO or RT-DETR. - The inference IoU and max-detections controls were shown only when the checkpoint name contained 'yolo11', hiding them for yolov12, yolo26 and rtdetr checkpoints. The condition now matches any yolo* checkpoint except YOLOS (a Transformers model), plus rtdetr. Finally, removed 281 lines of commented-out legacy UI at the foot of deeplearning_ui.R, after verifying every removed line was a comment or blank. It is preserved in git history. Verified with parse() on both files. The app was not run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ASR task
ASR was fully wired in the client but targets an API surface that no longer exists: no
/train/asrendpoint, noasrkey in the model registry, no ASR inference script. Selecting ASR populated nothing; submitting failed.Removed the training panel, inference panel, checkpoint finder, job submission, result outputs, and the four dropdown entries.
grep -i asracross the repo now returns nothing.Fix two object-detection conditionals
Both are real bugs, independent of ASR:
is_ultralytics_modelmatchesrtdetr), but the UI showed it the Transformers hyperparameters and hid the YOLO ones — solr0,momentum,warmup_epochsetc. were unreachable for RT-DETR runs. Both panels now key offYOLO || RT-DETR.yolo11. They were hidden foryolov12,yolo26, andrtdetrcheckpoints, all of which the API accepts them for. The condition now matches anyyolo*checkpoint exceptyolos(a Transformers model), plusrtdetr.Cleanup
Removed 281 lines of commented-out legacy UI at the foot of
deeplearning_ui.R. Every removed line was verified to be a comment or blank before deletion; it remains in git history.Net: +17 / −538.
Verification
parse()passes on both changed files. The app was not run — no Shiny server available. Please click through the DL tab (task switching, RT-DETR arch selection, inference panel) before merging.Open question
The
Hub & Loggingpanels still exposepush_to_hub,hub_user_id,log_to_wandb,wandb_project,wandb_entityfor all three tasks. The API ignores every one of them, and all training scripts setWANDB_DISABLED=true. These controls silently do nothing. I've left them in place pending a decision: finish the W&B integration, or remove the panels?🤖 Generated with Claude Code