Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions agent-service/src/agent/texera-agent.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,25 @@ describe("sendMessage", () => {
expect(agent.getAllSteps()[1].content).toBe("Error: just-a-string");
});

test.each([null, undefined, false, 0, ""])("a falsy throw resolves as an error step: %p", async thrown => {
const model = new MockLanguageModelV4({
doGenerate: async () => {
throw thrown;
},
});
const agent = makeAgentWith(model);
const res = await agent.sendMessage("hi");
const expected = String(thrown);
expect(res).toEqual({
response: "",
messages: [],
usage: { inputTokens: 0, outputTokens: 0, totalTokens: 0 },
stopped: false,
error: expected,
});
expect(agent.getAllSteps()[1].content).toBe(`Error: ${expected}`);
});

test("a failed turn stays on the branch", async () => {
const model = new MockLanguageModelV4({
doGenerate: async () => {
Expand Down
7 changes: 4 additions & 3 deletions agent-service/src/agent/texera-agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,8 @@ export class TexeraAgent {
stopped: false,
};
} catch (error: any) {
const isAborted = error.name === "AbortError" || this.abortController?.signal.aborted;
const errorMessage = error?.message || String(error);
const isAborted = error?.name === "AbortError" || this.abortController?.signal.aborted;

if (isAborted) {
stepIndex++;
Expand Down Expand Up @@ -693,7 +694,7 @@ export class TexeraAgent {
stepId: stepIndex,
timestamp: Date.now(),
role: "agent",
content: `Error: ${error.message || String(error)}`,
content: `Error: ${errorMessage}`,
isBegin: false,
isEnd: true,
};
Expand All @@ -705,7 +706,7 @@ export class TexeraAgent {
messages: [],
usage: { inputTokens: 0, outputTokens: 0, totalTokens: 0 },
stopped: false,
error: error.message || String(error),
error: errorMessage,
};
} finally {
this.abortController = null;
Expand Down
Loading