Skip to content

chore(frontend): remove the unused WorkflowSnapshotService - #7621

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/remove-workflow-snapshot-service
Open

chore(frontend): remove the unused WorkflowSnapshotService#7621
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/remove-workflow-snapshot-service

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes WorkflowSnapshotService, which calls REST endpoints that no longer exist, and the model type used only by it. Pure deletion, no behaviour change: −100 lines.

The service targets ${AppSettings.getApiEndpoint()}/snapshotPUT /snapshot/upload and GET /snapshot/{sid}. There is no @Path("/snapshot") resource anywhere in the Scala sources, so both requests would 404 if anything invoked them.

Nothing does. The service's only references are in execute-workflow.service.spec.ts, which imports it and calls TestBed.inject but never asserts on it — an inert injection, removed here along with the import and its field. WorkflowSnapshotEntry is used by the service and nowhere else.

Reviewer note: html2canvas stays — report-generation.service.ts uses it independently of this service.

Any related issues, documentation, discussions?

Closes #7618

How was this PR tested?

Existing tests only — this PR adds none; it removes a service nothing exercised.

Locally, from frontend/:

  • npx ng test --watch=false --include='**/execute-workflow.service.spec.ts' — 35 tests, all pass after dropping the inert injection.
  • yarn --cwd frontend format:ci — clean.

Verification, re-runnable by a reviewer:

git grep -n WorkflowSnapshotService             # only the deleted service after this change
git grep -n '@Path("/snapshot'  -- '*.scala'    # no backend route exists

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Copilot AI lite review requested due to automatic review settings August 13, 2026 03:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Aug 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (c35bdb1) to head (e5ff1b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7621      +/-   ##
============================================
+ Coverage     88.89%   88.90%   +0.01%     
  Complexity     4348     4348              
============================================
  Files          1179     1178       -1     
  Lines         46919    46906      -13     
  Branches       5230     5227       -3     
============================================
- Hits          41707    41702       -5     
+ Misses         3463     3455       -8     
  Partials       1749     1749              
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from c35bdb1
agent-service 98.62% <ø> (ø) Carriedforward from c35bdb1
amber 84.70% <ø> (ø) Carriedforward from c35bdb1
computing-unit-managing-service 60.38% <ø> (ø) Carriedforward from c35bdb1
config-service 77.31% <ø> (ø) Carriedforward from c35bdb1
file-service 68.90% <ø> (ø) Carriedforward from c35bdb1
frontend 90.61% <ø> (+0.03%) ⬆️
notebook-migration-service 78.89% <ø> (ø) Carriedforward from c35bdb1
pyamber 97.52% <ø> (ø) Carriedforward from c35bdb1
workflow-compiling-service 57.89% <ø> (ø) Carriedforward from c35bdb1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove WorkflowSnapshotService and its dead snapshot endpoints

3 participants