chore(frontend): remove the unused WorkflowSnapshotService - #7621
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(frontend): remove the unused WorkflowSnapshotService#7621aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
============================================
+ Coverage 88.89% 88.90% +0.01%
Complexity 4348 4348
============================================
Files 1179 1178 -1
Lines 46919 46906 -13
Branches 5230 5227 -3
============================================
- Hits 41707 41702 -5
+ Misses 3463 3455 -8
Partials 1749 1749
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
WorkflowSnapshotService, which calls REST endpoints that no longer exist, and the model type used only by it. Pure deletion, no behaviour change: −100 lines.The service targets
${AppSettings.getApiEndpoint()}/snapshot—PUT /snapshot/uploadandGET /snapshot/{sid}. There is no@Path("/snapshot")resource anywhere in the Scala sources, so both requests would 404 if anything invoked them.Nothing does. The service's only references are in
execute-workflow.service.spec.ts, which imports it and callsTestBed.injectbut never asserts on it — an inert injection, removed here along with the import and its field.WorkflowSnapshotEntryis used by the service and nowhere else.Any related issues, documentation, discussions?
Closes #7618
How was this PR tested?
Existing tests only — this PR adds none; it removes a service nothing exercised.
Locally, from
frontend/:npx ng test --watch=false --include='**/execute-workflow.service.spec.ts'— 35 tests, all pass after dropping the inert injection.yarn --cwd frontend format:ci— clean.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)