Skip to content

[MINOR] off-by-one error in CSV header writing #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t99-i wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

[MINOR] off-by-one error in CSV header writing #2557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/apache/sysds/runtime/instructions/spark/utils/FrameRDDConverterUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,9 +663,9 @@ public Iterator<String> call(Tuple2<Long, FrameBlock> arg0)
//handle header information and frame meta data
if( ix==1 ) {
if( _props.hasHeader() ) {
for(int j = 1; j <= blk.getNumColumns(); j++) {
sb.append(blk.getColumnNames()[j]
+ ((j<blk.getNumColumns()-1)?_props.getDelim():""));
for(int j = 0; j < blk.getNumColumns(); j++) {
sb.append(blk.getColumnNames()[j])
.append(j < blk.getNumColumns() - 1 ? _props.getDelim() : "");
}
ret.add(sb.toString());
sb.setLength(0); //reset
Expand Down