[SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message - #57821
Open
uros-b wants to merge 1 commit into
Open
[SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message#57821uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
commented
Aug 6, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Waiting for CI. @dongjoon-hyun Please review.
HyukjinKwon
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes the scalafmt failure message in
dev/lint-scala, which names the same path twice:The first path is corrected to
sql/api, so the message readssql/api or sql/connect.Why are the changes needed?
The check runs over
sql/apiplus four modules undersql/connect(common,server,shims,client/jvm), sosql/connect or sql/connectis a tautology that tells the reader nothing about the first module. The corrected wording matches the-plmodule list printed on the very next line of the same script.The duplication is a leftover of the module rename in SPARK-49428: the message previously read
sql/connect or connector/connect, and applying theconnector/connecttosql/connectrename to the message text collapsed both halves to the same path. Thesql/apimodule had been added to the check earlier, in SPARK-49511, without the message being updated.Does this PR introduce any user-facing change?
No. Developer-facing message text in a lint script only.
How was this patch tested?
No functional change. The edited string is inside an existing
echo -eand no test, CI workflow, or doc matches on this message text, so nothing consumes it programmatically.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)