Skip to content

[GH-3095] Exclude the entire Scala toolchain from shaded jars#3096

Merged
jiayuasu merged 1 commit into
apache:masterfrom
james-willis:exclude-scala-toolchain-from-shaded-jars
Jul 7, 2026
Merged

[GH-3095] Exclude the entire Scala toolchain from shaded jars#3096
jiayuasu merged 1 commit into
apache:masterfrom
james-willis:exclude-scala-toolchain-from-shaded-jars

Conversation

@james-willis

Copy link
Copy Markdown
Collaborator

Did you read the Contributor Guide?

Is this PR related to a ticket?

What changes were proposed in this PR?

Change the shade-plugin exclude in spark-shaded, flink-shaded, and snowflake from org.scala-lang:scala-library to org.scala-lang:*, so scala-reflect/scala-compiler can never be bundled unrelocated into the fat jars and shadow the runtime's Scala toolchain. See #3095 for details. The groupId match is exact, so org.scala-lang.modules:scala-collection-compat stays bundled.

How was this patch tested?

Verified on a downstream build hit by this that the shaded jar goes from containing an unrelocated scala-reflect 2.13.8 to zero scala/reflect/ or scala/tools/ entries, with scala/collection/compat/ still bundled.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@james-willis james-willis requested a review from jiayuasu as a code owner July 7, 2026 02:18
@jiayuasu jiayuasu added this to the sedona-1.9.1 milestone Jul 7, 2026
@jiayuasu jiayuasu merged commit c037e54 into apache:master Jul 7, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shaded jars should exclude the entire Scala toolchain (org.scala-lang:*), not just scala-library

2 participants