[GH-3095] Exclude the entire Scala toolchain from shaded jars#3096
Merged
jiayuasu merged 1 commit intoJul 7, 2026
Merged
Conversation
jiayuasu
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Shaded jars should exclude the entire Scala toolchain (org.scala-lang:*), not just scala-library #3095What changes were proposed in this PR?
Change the shade-plugin exclude in
spark-shaded,flink-shaded, andsnowflakefromorg.scala-lang:scala-librarytoorg.scala-lang:*, soscala-reflect/scala-compilercan never be bundled unrelocated into the fat jars and shadow the runtime's Scala toolchain. See #3095 for details. The groupId match is exact, soorg.scala-lang.modules:scala-collection-compatstays bundled.How was this patch tested?
Verified on a downstream build hit by this that the shaded jar goes from containing an unrelocated
scala-reflect2.13.8 to zeroscala/reflect/orscala/tools/entries, withscala/collection/compat/still bundled.Did this PR include necessary documentation updates?