[ISSUE #10852] fix(broker): sort revive offsets without overflow - #10857
Open
yuluo-yx wants to merge 1 commit into
Open
[ISSUE #10852] fix(broker): sort revive offsets without overflow#10857yuluo-yx wants to merge 1 commit into
yuluo-yx wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10857 +/- ##
=============================================
- Coverage 48.37% 48.31% -0.07%
+ Complexity 13555 13535 -20
=============================================
Files 1380 1380
Lines 101165 101165
Branches 13127 13127
=============================================
- Hits 48940 48877 -63
- Misses 46250 46300 +50
- Partials 5975 5988 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Aug 8, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean fix — replacing (int)(a - b) with Long.compare(a, b) eliminates the integer overflow risk when offsets differ by more than Integer.MAX_VALUE. The test case covering Long.MAX_VALUE offset gap is well-chosen.
Automated review by github-manager-bot
Member
Author
|
I confirmed the CI failure is not caused by this PR. Please rerun CI, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Uses Long.compare to keep Pop revive checkpoints ordered by their full-width long offsets. Adds a regression test with offsets spanning the long range.
How Did You Test This Change?
mise x java@temurin-17 -- mvn -Dmaven.repo.local=/private/tmp/rocketmq-m2 -pl broker -am -DskipITs -Dtest=PopReviveServiceTest -Dsurefire.failIfNoSpecifiedTests=false testThe targeted tests, Checkstyle, and SpotBugs completed successfully.