Skip to content

[ISSUE #10838] fix(route): skip malformed ordered topic entries - #10848

Open
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-10
Open

[ISSUE #10838] fix(route): skip malformed ordered topic entries#10848
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-10

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Aug 8, 2026

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Brief Description

Skip malformed ordered-topic entries in both client and proxy route conversion while retaining valid broker queue definitions.

How Did You Test This Change?

  • mise x java@temurin-17 -- mvn -pl client -am -Dtest=MQClientInstanceTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mise x java@temurin-17 -- mvn -pl proxy -am -Dtest=MessageQueueSelectorTest -Dsurefire.failIfNoSpecifiedTests=false test

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.32%. Comparing base (fd0c959) to head (fe94ef1).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10848      +/-   ##
=============================================
- Coverage      48.37%   48.32%   -0.06%     
+ Complexity     13555    13537      -18     
=============================================
  Files           1380     1380              
  Lines         101165   101175      +10     
  Branches       13127    13129       +2     
=============================================
- Hits           48940    48891      -49     
- Misses         46250    46299      +49     
- Partials        5975     5985      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good defensive fix — adds bounds checking (split(":", 2) + length check) and NumberFormatException handling for malformed orderTopicConf entries. The continue approach correctly skips bad entries without breaking the entire route parsing. Applied consistently across both MQClientInstance and MessageQueueSelector.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed orderTopicConf crashes client and proxy route conversion

3 participants