Skip to content

[ISSUE #10837] fix(client): skip truncated trace records - #10847

Open
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-9
Open

[ISSUE #10837] fix(client): skip truncated trace records#10847
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-9

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Aug 8, 2026

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Brief Description

Validate the minimum field count for each trace type so truncated records are skipped and later valid records are still decoded.

How Did You Test This Change?

  • mise x java@temurin-17 -- mvn -pl client -am -Dtest=TraceDataEncoderTest -Dsurefire.failIfNoSpecifiedTests=false test

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.29%. Comparing base (fd0c959) to head (f85729c).

Files with missing lines Patch % Lines
...apache/rocketmq/client/trace/TraceDataEncoder.java 20.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10847      +/-   ##
=============================================
- Coverage      48.37%   48.29%   -0.09%     
+ Complexity     13555    13534      -21     
=============================================
  Files           1380     1380              
  Lines         101165   101165              
  Branches       13127    13127              
=============================================
- Hits           48940    48856      -84     
- Misses         46250    46317      +67     
- Partials        5975     5992      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Solid defensive fix — adds length validation before accessing trace record fields, preventing ArrayIndexOutOfBoundsException on truncated/corrupted trace data. The MessageTraceUtils changes correctly skip incomplete records while preserving valid ones.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TraceDataEncoder fails after a truncated trace record

3 participants