[ISSUE #10834] fix(remoting): parse bracketed IPv6 broker addresses - #10844
Open
yuluo-yx wants to merge 1 commit into
Open
[ISSUE #10834] fix(remoting): parse bracketed IPv6 broker addresses#10844yuluo-yx wants to merge 1 commit into
yuluo-yx wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10844 +/- ##
=============================================
- Coverage 48.37% 48.32% -0.05%
+ Complexity 13555 13541 -14
=============================================
Files 1380 1380
Lines 101165 101171 +6
Branches 13127 13130 +3
=============================================
- Hits 48940 48893 -47
- Misses 46250 46289 +39
- Partials 5975 5989 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Aug 8, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Important fix for IPv6 support — the original split(":") approach completely breaks on bracketed IPv6 addresses like [2001:db8::1]:10911. The new implementation correctly handles:
- Bracketed IPv6:
[addr]:port→ extracts host between brackets - IPv4:
host:port→ extracts host before colon - No-port addresses → returns full address
Good test coverage including edge cases.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Parse bracketed IPv6 broker addresses without truncating the host while preserving IPv4 and host-only behavior.
How Did You Test This Change?
mise x java@temurin-17 -- mvn -pl remoting -am -Dtest=RemotingHelperTest -Dsurefire.failIfNoSpecifiedTests=false test